Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24702 )
Change subject: IMPALA-15115: Fix race condition in GetOperationStatus with query retries ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24702/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/24702/1/be/src/service/impala-hs2-server.cc@932 PS1, Line 932: while (true) { The loop looks harder to understand to me than necessary. An idea to make this simpler is adding a function to ClientRequestState that collects interesting info under lock, so this could look like: Status status = query_handle->GetState(&operation_state, &query_was_retried); if (query_was_retried) { GetActiveQueryHandle(query_id, &query_handle); status = query_handle->GetState(&operation_state, &query_was_retried); DCHECK(!query_was_retried) } // set response based on results http://gerrit.cloudera.org:8080/#/c/24702/1/tests/custom_cluster/test_query_retries.py File tests/custom_cluster/test_query_retries.py: http://gerrit.cloudera.org:8080/#/c/24702/1/tests/custom_cluster/test_query_retries.py@1070 PS1, Line 1070: beeswax_client I don't like the duplication of test code for beeswax/hs2, but I assume that we can remove beeswax in the not too long future. -- To view, visit http://gerrit.cloudera.org:8080/24702 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9934a797650eec57b8280e6a6d2ef252dac00c69 Gerrit-Change-Number: 24702 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 19:55:17 +0000 Gerrit-HasComments: Yes
