Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24508 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after 
HIVE-26537
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24508/10/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
File fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java:

http://gerrit.cloudera.org:8080/#/c/24508/10/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java@118
PS10, Line 118: CatalogHmsAPIHelper
I just realized that at 
https://github.com/apache/impala/blame/7227d81/fe/pom.xml#L1452 we exclude 
CatalogHmsAPIHelper when building with Apache Hive 3. Thus we got the following 
compilation error.

 09:48:27 16:48:25 [ERROR] 
/home/ubuntu/Impala/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java:[118,25]
 cannot find symbol
 09:48:27 16:48:25 [ERROR]   symbol:   variable CatalogHmsAPIHelper
 09:48:27 16:48:25 [ERROR]   location: class 
org.apache.impala.catalog.MetastoreApiTestUtils

To fix this, we either include CatalogHmsAPIHelper, or just bring back that 
static createHmsDatabaseObject(). The latter may be easier since it does not 
involve changing the dependencies when building with Apache Hive 3.



--
To view, visit http://gerrit.cloudera.org:8080/24508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bb2e4169e5252ff18da3090aecefc9ac5473499
Gerrit-Change-Number: 24508
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Fri, 21 Aug 2026 18:11:43 +0000
Gerrit-HasComments: Yes

Reply via email to