Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )
Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537 ...................................................................... Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG@7 PS8, Line 7: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537 > Shouldn't use CDPD ticket number. Done http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG@9 PS8, Line 9: HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that > This won't build until we build against a version of Hive with that change. It turns out this patch could pass https://jenkins.impala.io/job/all-build-options-ub2004/4719/. I also triggered https://jenkins.impala.io/job/gerrit-verify-dryrun-external/3782/ against the chain of commits to see how things are going. http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java File fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java: http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java@50 PS5, Line 50: import org.apache.hadoop.hive.metastore.api.FileMetadata; > unused import: org.apache.hadoop.hive.metastore.api.FieldSchema Done http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@57 PS5, Line 57: import org.apache.hadoop.hive.metastore.api.RenamePartitionRequest; > unused import: org.apache.hadoop.hive.metastore.api.PrincipalType Done http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@57 PS6, Line 57: import org.apache.hadoop.hive.metastore.api.RenamePartitionRequest; > unused import: org.apache.hadoop.hive.metastore.api.PrincipalType Done http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java File fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java: http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java@41 PS5, Line 41: import org.apache.hadoop.hive.metastore.api.StorageDescriptor; > unused import: org.apache.hadoop.hive.metastore.api.PrincipalType Done http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java File fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java: http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java@41 PS6, Line 41: import org.apache.hadoop.hive.metastore.api.StorageDescriptor; > unused import: org.apache.hadoop.hive.metastore.api.PrincipalType Done -- To view, visit http://gerrit.cloudera.org:8080/24483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9 Gerrit-Change-Number: 24483 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2026 22:26:04 +0000 Gerrit-HasComments: Yes
