Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24484
to look at the new patch set (#6).
Change subject: IMPALA-15010: Patch gperftools to use size_t for thread cache
sizes
......................................................................
IMPALA-15010: Patch gperftools to use size_t for thread cache sizes
This bumps the toolchain, which included a few different fixes.
The primary fix is that gperftools has been patched to use
size_t for thread cache sizes. This would prevent exotic
scenarios where the thread cache size integer could wrap
around to become negative. Google TCMalloc had already made
this change for their thread caching implementation.
The new toolchain also has a different structure for the
layout of the ARM hadoop-client tarball for IMPALA-12975.
When the existing logic in buildall.sh copies the binaries
to the regular HADOOP_HOME, there is a time when the
binaries are partially written that can crash the minicluster.
The original idea for a fix was to leave the ARM binaries
in a different directory and refer to them there.
It turns out to be tedious to get the minicluster to respect
libraries at a separate location from the HADOOP_HOME
location. Instead, this modifies the logic in buildall.sh to
set up a symlink to the ARM hadoop-client location and
only modify it if it is pointing to the wrong place. This
should avoid disrupting a running minicluster.
Testing:
- Ran core jobs on x86_64 and ARM
- Ran a perf-AB-test on ARM
Change-Id: I9dc5e95352f593918f9cacf26786149c8c79b4a2
---
M bin/impala-config.sh
M buildall.sh
2 files changed, 29 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/24484/6
--
To view, visit http://gerrit.cloudera.org:8080/24484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dc5e95352f593918f9cacf26786149c8c79b4a2
Gerrit-Change-Number: 24484
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
