Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24484 )

Change subject: IMPALA-15010: Patch gperftools to use size_t for thread cache 
sizes
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24484/6/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/24484/6/buildall.sh@458
PS6, Line 458:   # Use prebuilt Hadoop native binaries for aarch64
> We'll be able to get rid of all of this once https://gerrit.cloudera.org/c/
Yeah, if we had separate Hadoop ARM tarballs, that would avoid this. A newer 
GBN would have them. We'll have a couple changes to make to upload / use them.


http://gerrit.cloudera.org:8080/#/c/24484/6/buildall.sh@464
PS6, Line 464:     
ARM_HADOOP_LIB_DIR="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/hadoop-client-${IMPALA_HADOOP_CLIENT_VERSION}/lib"
> line too long (108 > 90)
There are ways to break this line, but I think this is cleaner. I'm inclined to 
leave this as-is.



--
To view, visit http://gerrit.cloudera.org:8080/24484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dc5e95352f593918f9cacf26786149c8c79b4a2
Gerrit-Change-Number: 24484
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Fri, 21 Aug 2026 21:20:31 +0000
Gerrit-HasComments: Yes

Reply via email to