Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24718 )
Change subject: IMPALA-15278: Fix incorrect cardinality with OFFSET ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24718/1/fe/src/main/java/org/apache/impala/planner/SortNode.java File fe/src/main/java/org/apache/impala/planner/SortNode.java: http://gerrit.cloudera.org:8080/#/c/24718/1/fe/src/main/java/org/apache/impala/planner/SortNode.java@307 PS1, Line 307: Preconditions.checkState(offset_ == 0, "Tie handling with offset not supported"); > Should this be a precondition or throw an actual exception? It's unclear to There is a precondition for this: https://github.com/apache/impala/blob/5dc944e13c8ff3aaa3b0c75ff45416ebe9c5e4e2/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java#L1379-L1380 I just mirror it here to make the code more readable. http://gerrit.cloudera.org:8080/#/c/24718/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/24718/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@131 PS1, Line 131: runPlannerTestFile("card-limit-offset", > Is this supposed to be a new test? I don't see it added in the patch. Oops, forgot to add this file.. -- To view, visit http://gerrit.cloudera.org:8080/24718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b628beabc5c7ec6c4fdda9dff6aaf7a4acae538 Gerrit-Change-Number: 24718 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 22 Aug 2026 00:04:47 +0000 Gerrit-HasComments: Yes
