Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24718 )
Change subject: IMPALA-15278: Fix incorrect cardinality with OFFSET ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24718/3/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/24718/3/fe/src/main/java/org/apache/impala/planner/PlanNode.java@816 PS3, Line 816: protected long capCardinalityAtLimit(long cardinality, long offset) { > Worth a second look at what a zero does downstream. subquery-rewrite.test i That makes sense. applySelectivity() also does this for IMPALA-8647. http://gerrit.cloudera.org:8080/#/c/24718/3/testdata/workloads/functional-planner/queries/PlannerTest/card-limit-offset.test File testdata/workloads/functional-planner/queries/PlannerTest/card-limit-offset.test: http://gerrit.cloudera.org:8080/#/c/24718/3/testdata/workloads/functional-planner/queries/PlannerTest/card-limit-offset.test@16 PS3, Line 16: # OFFSET in MERGING-EXCHANGE > The new file covers offset below the estimate (7.30K rows, offset 6200) in Added such tests. -- To view, visit http://gerrit.cloudera.org:8080/24718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b628beabc5c7ec6c4fdda9dff6aaf7a4acae538 Gerrit-Change-Number: 24718 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 01 Sep 2026 06:05:31 +0000 Gerrit-HasComments: Yes
