Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24634 )

Change subject: IMPALA-12889: Changing file format to AVRO doesn't update 
schema using 'avro.schema.url'
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24634/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/24634/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1373
PS2, Line 1373:               tbl.getMetaStoreTable().getSd().getInputFormat(),
              :               
tbl.getMetaStoreTable().getSd().getSerdeInfo().getSerializationLib());
For partition level file format changes, we need to get this from the 
partition. There is a test table that you can play with: 
functional.alltypesmixedformat


http://gerrit.cloudera.org:8080/#/c/24634/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7407
PS2, Line 7407: .
nit: add "it" at the end? "lowercases it". Or we can simply remove this 
comment. It's obvious.



--
To view, visit http://gerrit.cloudera.org:8080/24634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0aaf707fb2879b26518f8b6d532087f92d85dfcb
Gerrit-Change-Number: 24634
Gerrit-PatchSet: 2
Gerrit-Owner: Tarun Jangid <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Tarun Jangid <[email protected]>
Gerrit-Comment-Date: Sun, 23 Aug 2026 02:55:57 +0000
Gerrit-HasComments: Yes

Reply via email to