Aleksandr Efimov has posted comments on this change. (
http://gerrit.cloudera.org:8080/24693 )
Change subject: IMPALA-15236: Expose HBO match provenance
......................................................................
Patch Set 6:
Took the advice and built a minicluster. It paid for itself on the first run:
two of the assertions I had added could never have passed.
test_matching_provenance passed {'explain_level': 2} and
{'enable_explain_hbo': True} as per-query options, and
ImpalaTestSuite.__execute_query calls set_configuration(), which replaces the
configuration instead of merging into it. So those queries ran without
USE_HBO_STATS and STORE_HBO_STATS: no match was recorded, and the profile had
no "HBO match:" line to assert on. All three call sites now use
{**QUERY_OPTIONS, ...}.
test_effective_runtime_filters and
test_runtime_filter_annotation_with_hbo_cardinality expected
"(from HBO EXPR_REWRITE)". getExplainCaveat() returns "" for EXPR_REWRITE by
design, so an expression-rewrite match reads "(from HBO)". Both assertions are
corrected.
While I was in there: a javadoc block had ended up above
profileExplainDiffers() instead of getProfileExplainString(), and the new
QUERY_OPT_FN entry was split over two lines although it fits in 83 columns -
every other split entry in that table actually needs the split.
TestHBO is 18 passed, 2 failed. Both failures are "Could not resolve table
reference" for tpch.lineitem and tpch_parquet.lineitem, which my local data set
does not have, so test_cancellation and
test_runtime_filter_annotation_with_hbo_cardinality do not run here. The
corrected string in the latter therefore rests on the dry-run rather than on
me. HistoricalStatsTest is 8/8.
The accuracy rate, the unavailable case and the EXPLAIN wording are still yours
to call - I have not touched them, and replies on those go in their own threads
from here on.
--
To view, visit http://gerrit.cloudera.org:8080/24693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2deaaf78a2a41353454ba634a247d8c69825bf
Gerrit-Change-Number: 24693
Gerrit-PatchSet: 6
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Mon, 24 Aug 2026 07:55:26 +0000
Gerrit-HasComments: No
