Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24693 )
Change subject: IMPALA-15236: Expose HBO match provenance ...................................................................... Patch Set 7: Loaded TPC-H after all: testdata/datasets/tpch/preload generates it with the toolchain's dbgen, so "not in my local data set" was wrong rather than unavoidable. With lineitem and orders present, test_cancellation and test_runtime_filter_annotation_with_hbo_cardinality both pass, so the caveat in my last comment is withdrawn - TestHBO is 20 of 20. Running them turned up something a single run does not show: test_matching_provenance was not re-runnable. It passes on a fresh HBO history, fails on a second run against the same cluster, and passes again after a restart, measured in that order. The aggressive year=2010 query is recorded by its own first execution, so the second run matches it exactly through EXPR_REWRITE instead of falling through to IGNORE_PARTITION_CONSTANTS, and the "partition constants ignored" assertion fails. CI would not see this because every run gets a fresh cluster; anyone re-running the test locally would. PS7 gives the string literal a per-run suffix so a run cannot match itself. Three consecutive full-suite runs against one cluster now pass, 20 of 20 each, with no restart in between. HistoricalStatsTest is 8/8. -- To view, visit http://gerrit.cloudera.org:8080/24693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d2deaaf78a2a41353454ba634a247d8c69825bf Gerrit-Change-Number: 24693 Gerrit-PatchSet: 7 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 24 Aug 2026 08:14:22 +0000 Gerrit-HasComments: No
