Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24717 )

Change subject: IMPALA-15277: Address test failures related 
MetastoreEventsProcessorTest
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24717/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:

http://gerrit.cloudera.org:8080/#/c/24717/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3947
PS7, Line 3947:     boolean foundCommitCompaction = false;
              :     for (MetastoreEvent filteredEvent : filteredEvents) {
              :       if (filteredEvent.getEventType() == 
MetastoreEventType.COMMIT_COMPACTION_EVENT) {
              :         foundCommitCompaction = true;
              :         break;
              :       }
              :     }
This is not the same check as before. We should have checked the last event in 
filteredEvents only. Let me correct this in the next patch.



--
To view, visit http://gerrit.cloudera.org:8080/24717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d810609fccaac73a0eb4e3f2e257521a3da10f
Gerrit-Change-Number: 24717
Gerrit-PatchSet: 7
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Tue, 25 Aug 2026 00:05:01 +0000
Gerrit-HasComments: Yes

Reply via email to