Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24717 )
Change subject: IMPALA-15277: Address test failures related MetastoreEventsProcessorTest ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/24717/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/24717/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3947 PS7, Line 3947: event = filteredEvents.get(filteredEvents.size() - 1); : if (event.getEventType() != MetastoreEventType.COMMIT_COMPACTION_EVENT) { : StringBuilder sb = new StringBuilder(); : sb.append("The last event must be a COMMIT_COMPACTION_EVENT. Filtered events:\n"); : for (MetastoreEvent filteredEvent : filteredEvents) { : sb.append(" ").append(filteredEvent).append('\n'); : > This is not the same check as before. We should have checked the last event Done -- To view, visit http://gerrit.cloudera.org:8080/24717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d810609fccaac73a0eb4e3f2e257521a3da10f Gerrit-Change-Number: 24717 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2026 15:23:31 +0000 Gerrit-HasComments: Yes
