Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24715 )
Change subject: Use Calcite for expr-test ...................................................................... Patch Set 1: (2 comments) Came at this from the other side today, while going through 24260. Two notes. http://gerrit.cloudera.org:8080/#/c/24715/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/24715/1/be/src/exprs/expr-test.cc@208 PS1, Line 208: FLAGS_use_calcite_planner=true; This flag already gets you PLANNER=CALCITE - InitializeConfigVariables() maps it onto default_query_options_.planner in impala-server.cc - so the PushExecOption below applies the same switch a second time. Is one of them covering a path the other misses, or can it be just one? Tiny thing: spaces around the '='. http://gerrit.cloudera.org:8080/#/c/24715/1/be/src/exprs/expr-test.cc@253 PS1, Line 253: executor_->PushExecOption("PLANNER=CALCITE"); fallback_planner stays at its default of ORIGINAL, so anything Calcite cannot compile silently re-plans on the original planner and the test still passes. I measured that on a different file today: binary_exprs_with_boolean.test from 24217 runs 29 of its 37 statements under planner=calcite and fails the eight negative ones with different wording - and with fallback_planner=original the whole file is green. Concretely for this file: the two rows 24260 just added - truncate(cast('3.1615' as decimal(6,4)), cast(1 as int)) and the TestNonOkStatus with cast(null as int) - fail under Calcite with "must be called with a constant second argument", because SqlUtil.isLiteral only unwraps SqlKind.CAST while an explicit cast in that planner is EXPLICIT_CAST with SqlKind.OTHER. With FALLBACK_PLANNER=NONE this patch would surface that; as written it will not. Would adding PushExecOption("FALLBACK_PLANNER=NONE") fit what you have in mind, or is keeping the fallback deliberate for the first pass? -- To view, visit http://gerrit.cloudera.org:8080/24715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b267fc1ec2335dfd5daa5715599842857b355c8 Gerrit-Change-Number: 24715 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2026 16:38:16 +0000 Gerrit-HasComments: Yes
