Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24737 )

Change subject: IMPALA-14759: Upgrade to Boost 1.91
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24737/2/be/src/rpc/authentication.cc
File be/src/rpc/authentication.cc:

http://gerrit.cloudera.org:8080/#/c/24737/2/be/src/rpc/authentication.cc@80
PS2, Line 80: using namespace boost::filesystem;   // for is_regular_file(), 
is_absolute()
> We could consider moving to std::filesystem.
Yes, it would be good to use standard library where possible. Filed 
IMPALA-15311. Filesystem is a good candidate.



--
To view, visit http://gerrit.cloudera.org:8080/24737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d6ef3e4793faac9b6ca9b4730671dca4bf99da5
Gerrit-Change-Number: 24737
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 26 Aug 2026 23:52:51 +0000
Gerrit-HasComments: Yes

Reply via email to