Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21967 )
Change subject: IMPALA-13976: Switch from boost::function/bind/mem_fn to std ...................................................................... Patch Set 4: > I did a git grep -E "boost::(function|bind|mem_fn)" on the codebase > and found a few remaining places. Do you think we should replace > these as well? > be/src/runtime/coordinator-backend-state.cc: > boost::bind(&Coordinator::BackendState::PublishFilterCompleteCb, > this, &controller, > be/src/runtime/runtime-filter-bank.cc: boost::bind( > be/src/runtime/runtime-filter-bank.cc: boost::bind( > be/src/udf/udf-test-harness.h: static bool > ValidateUdf(boost::function<RET(FunctionContext*)> > fn, > be/src/udf/udf-test-harness.h: static bool > ValidateUdf(boost::function<RET(FunctionContext*, > const A1&)> fn, > be/src/udf/udf-test-harness.h: static bool > ValidateUdf(boost::function<RET(FunctionContext*, > int, const A1*)> fn, > be/src/udf/udf-test-harness.h: boost::function<RET(FunctionContext*, > const A1&, const A2&)> fn, > ... > be/src/util/blocking-queue-test.cc: new > thread(boost::bind(&MultiThreadTest::InserterThread, > this, i)))); > be/src/util/blocking-queue-test.cc: new > thread(boost::bind(&MultiThreadTest::RemoverThread, > this)))); > be/src/util/blocking-queue-test.cc: new > thread(boost::bind( Thanks, I switched those locations to use std::function/bind, except for udf-test-harness.h, which claims to support C++98. -- To view, visit http://gerrit.cloudera.org:8080/21967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I769d84b02fbe691b3bf2a6d3f52836d5b684bae0 Gerrit-Change-Number: 21967 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2026 19:44:07 +0000 Gerrit-HasComments: No
