Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21967 )
Change subject: IMPALA-13976: Switch from boost::function/bind/mem_fn to std ...................................................................... IMPALA-13976: Switch from boost::function/bind/mem_fn to std Impala's code uses boost::function/bind/mem_fn in several places, but all of this has been incorporated into the standard library. When trying to upgrade to newer Boost (1.91.0), the use of boost::bind and other functionality created conflicts with the standard library. Given that there is no real advantage to staying with the Boost version of these, this switches all locations to the standard library. One difference is that boost::function has a different API from std::function. boost::function uses empty() to determine if it is null whereas std::function can simply be compared to null. Overall, these differences are minor and this is simply a boilerplate change. This leaves some uses of boost::function in udf-test-harness.h, as that file claims to support C++98. These can be removed when we move that to a more recent C++ version. Testing: - Ran a core job Change-Id: I769d84b02fbe691b3bf2a6d3f52836d5b684bae0 Reviewed-on: http://gerrit.cloudera.org:8080/21967 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Yida Wu <[email protected]> Tested-by: Michael Smith <[email protected]> --- M be/src/benchmarks/process-wide-locks-benchmark.cc M be/src/benchmarks/thread-create-benchmark.cc M be/src/catalog/catalog-server.cc M be/src/common/names.h M be/src/exec/base-sequence-scanner.cc M be/src/exec/blocking-join-node.cc M be/src/exec/exec-node.cc M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node.cc M be/src/exec/kudu/kudu-scan-node.cc M be/src/exec/kudu/kudu-table-sink.cc M be/src/exec/scan-node.cc M be/src/exec/scanner-context.cc M be/src/exec/scanner-context.h M be/src/rpc/rpc-trace.cc M be/src/rpc/thrift-thread.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/buffered-tuple-stream.cc M be/src/runtime/buffered-tuple-stream.h M be/src/runtime/bufferpool/buffer-allocator.cc M be/src/runtime/bufferpool/buffer-pool-internal.h M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/client-cache.h M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/exec-env.cc M be/src/runtime/fragment-instance-state.cc M be/src/runtime/io/data-cache-test.cc M be/src/runtime/io/data-cache.cc M be/src/runtime/io/disk-io-mgr-test.cc M be/src/runtime/krpc-data-stream-mgr.cc M be/src/runtime/krpc-data-stream-recvr.cc M be/src/runtime/krpc-data-stream-sender.cc M be/src/runtime/mem-tracker-test.cc M be/src/runtime/query-exec-mgr.cc M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/sorted-run-merger.h M be/src/runtime/sorter.cc M be/src/runtime/thread-resource-mgr-test.cc M be/src/runtime/thread-resource-mgr.cc M be/src/runtime/thread-resource-mgr.h M be/src/runtime/tmp-file-mgr-test.cc M be/src/scheduling/admission-control-service.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/cluster-membership-mgr.cc M be/src/service/child-query.cc M be/src/service/client-request-state.cc M be/src/service/impala-hs2-server.cc M be/src/service/impala-server.cc M be/src/statestore/statestore-subscriber.h M be/src/statestore/statestore.cc M be/src/util/blocking-queue-test.cc M be/src/util/coding-util.cc M be/src/util/default-path-handlers.cc M be/src/util/internal-queue.h M be/src/util/metrics.cc M be/src/util/metrics.h M be/src/util/pprof-path-handlers.cc M be/src/util/runtime-profile-counters.h M be/src/util/runtime-profile-periodic.cc M be/src/util/runtime-profile-test.cc M be/src/util/runtime-profile.cc M be/src/util/runtime-profile.h M be/src/util/thread-pool.h M be/src/util/thread.h M be/src/util/webserver-test.cc M be/src/util/webserver.cc M be/src/util/webserver.h 68 files changed, 231 insertions(+), 137 deletions(-) Approvals: Michael Smith: Looks good to me, approved; Verified Yida Wu: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/21967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I769d84b02fbe691b3bf2a6d3f52836d5b684bae0 Gerrit-Change-Number: 21967 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
