Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10910 )
Change subject: IMPALA-2422: Fix escaping in the LIKE clause ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10910/1/be/src/exprs/like-predicate.cc File be/src/exprs/like-predicate.cc: http://gerrit.cloudera.org:8080/#/c/10910/1/be/src/exprs/like-predicate.cc@265 PS1, Line 265: StringValue tmp_val = StringValue::FromStringVal(val); ws http://gerrit.cloudera.org:8080/#/c/10910/1/fe/src/main/java/org/apache/impala/analysis/LikePredicate.java File fe/src/main/java/org/apache/impala/analysis/LikePredicate.java: http://gerrit.cloudera.org:8080/#/c/10910/1/fe/src/main/java/org/apache/impala/analysis/LikePredicate.java@132 PS1, Line 132: StringLiteral basic question: what happens with the interaction between constant folding and analyzing this predicate? my understanding is that child[1] will get replaced; if its replaced with some string that should be unescaped, is it analyzed at the right time so that this flag is flipped? if there isn't a test for this, lets add one. http://gerrit.cloudera.org:8080/#/c/10910/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java: http://gerrit.cloudera.org:8080/#/c/10910/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@a304 PS1, Line 304: basic question: this changes the test. are inputs expected to change? just checking if there is any compatibility issue here. -- To view, visit http://gerrit.cloudera.org:8080/10910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I553412318525820a36d2f401aa7e93958d22f70e Gerrit-Change-Number: 10910 Gerrit-PatchSet: 1 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 11 Jul 2018 02:19:36 +0000 Gerrit-HasComments: Yes
