Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10910 )
Change subject: IMPALA-2422: Fix escaping in the LIKE clause ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10910/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/10910/2/be/src/exprs/expr-test.cc@3481 PS2, Line 3481: // We return a different result if the second argument is not a string literal. Am I understanding this right that LIKE now behaves differently depending on whether its argument is constant or a variable that evaluates to the same value? That's going to cause a lot of issues... -- To view, visit http://gerrit.cloudera.org:8080/10910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I553412318525820a36d2f401aa7e93958d22f70e Gerrit-Change-Number: 10910 Gerrit-PatchSet: 2 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 12 Jul 2018 21:21:41 +0000 Gerrit-HasComments: Yes
