Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24506 )
Change subject: IMPALA-15201: Enable comparison operators and predicates for UUID type ...................................................................... IMPALA-15201: Enable comparison operators and predicates for UUID type Add support for comparison operators (=, !=, <, >, <=, >=, IS [NOT] DISTINCT FROM) and predicates (IN, NOT IN, IS NULL, IS NOT NULL, BETWEEN) on UUID columns in Iceberg tables. UuidCompatibility blocks all implicit casts between UUID and other types, so predicates must use UUID-typed expressions (e.g. column references or scalar subqueries) rather than string literals. Backend changes: - Add UUID comparison operators using memcmp on 16-byte canonical representation. Comparison uses RFC 4122 byte ordering. Frontend changes: - Remove UUID guards from BinaryPredicate, InPredicate, IsNullPredicate - Keep UuidCompatibility blocking both STRING->UUID and UUID->STRING implicit promotion - Block explicit UUID<->STRING casts (deferred to IMPALA-15202) Testing: - Add positive tests for =, !=, range, IN, NOT IN, BETWEEN, JOIN, and null checks using scalar subqueries to supply UUID-typed values - Add negative tests confirming string literals are rejected in predicates and explicit casts remain blocked Change-Id: I0e8c4c631ccc25a5f2da3540c2d18cf9dba79fe9 Assisted-by: Composer 2.5 Reviewed-on: http://gerrit.cloudera.org:8080/24506 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exprs/operators-ir.cc M be/src/exprs/operators.h M common/function-registry/impala_functions.py M fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java M fe/src/main/java/org/apache/impala/analysis/InPredicate.java M fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java M testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test 7 files changed, 227 insertions(+), 25 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0e8c4c631ccc25a5f2da3540c2d18cf9dba79fe9 Gerrit-Change-Number: 24506 Gerrit-PatchSet: 10 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
