Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24506 )
Change subject: IMPALA-15201: Enable comparison operators and predicates for UUID type ...................................................................... Patch Set 7: Code-Review+1 (3 comments) Some minor findings, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/24506/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24506/7//COMMIT_MSG@9 PS7, Line 9: Add support for comparison operators (=, !=, <, >, <=, >=) and IS [NOT] DISTINCT FROM could be also added and tested http://gerrit.cloudera.org:8080/#/c/24506/7//COMMIT_MSG@19 PS7, Line 19: - Comparison uses RFC 4122 byte ordering nit: Could be merged to the first point http://gerrit.cloudera.org:8080/#/c/24506/7//COMMIT_MSG@27 PS7, Line 27: ORDER BY, GROUP BY We already had a test that used "GROUP BY uuid_col ORDER BY uuid_col" -- To view, visit http://gerrit.cloudera.org:8080/24506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e8c4c631ccc25a5f2da3540c2d18cf9dba79fe9 Gerrit-Change-Number: 24506 Gerrit-PatchSet: 7 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2026 13:34:40 +0000 Gerrit-HasComments: Yes
