Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24661 )
Change subject: IMPALA-15247: Unify not-comparable type checks in Type.throwIfNotComparable ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24661/4/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/24661/4/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@362 PS4, Line 362: child.getType().throwIfNotComparable("DISTINCT aggregate parameter", child); > I think that the lost info is not that important, the user should be able t Started the tests as I got +2 from Peter and would like to to rebase my geometry patch once this is merged. If you would like this changed, I can do it in another patch. -- To view, visit http://gerrit.cloudera.org:8080/24661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dc2c4579508cf1f8954ac251087c52f2eddf36a Gerrit-Change-Number: 24661 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2026 16:29:43 +0000 Gerrit-HasComments: Yes
