Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24661 )
Change subject: IMPALA-15247: Unify not-comparable type checks in Type.throwIfNotComparable ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/24661/4/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/24661/4/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@362 PS4, Line 362: child.getType().throwIfNotComparable("DISTINCT aggregate parameter", child); > The old message also named the aggregate itself ("... in aggregate function I think that the lost info is not that important, the user should be able to deduce the offending aggregate from the info we print. Can rewrite it if you disagree. http://gerrit.cloudera.org:8080/#/c/24661/4/fe/src/main/java/org/apache/impala/catalog/Type.java File fe/src/main/java/org/apache/impala/catalog/Type.java: http://gerrit.cloudera.org:8080/#/c/24661/4/fe/src/main/java/org/apache/impala/catalog/Type.java@284 PS4, Line 284: } > One thing that may be worth a line in the commit message: this branch is no In the meantime uuid added operator suppiort, so this can be removed. http://gerrit.cloudera.org:8080/#/c/24661/4/fe/src/main/java/org/apache/impala/catalog/Type.java@292 PS4, Line 292: public void throwIfNotComparable(String exprDesc, Expr expr) throws AnalysisException { > The single call site that passes null shows the cost of one shared template Replaced the single call site with a "handmade" exception. -- To view, visit http://gerrit.cloudera.org:8080/24661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dc2c4579508cf1f8954ac251087c52f2eddf36a Gerrit-Change-Number: 24661 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2026 14:45:30 +0000 Gerrit-HasComments: Yes
