Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24811 )
Change subject: IMPALA-15282: Export Substrait plan from Calcite planner (prototype) ...................................................................... Patch Set 1: On the precision clamp: it is not only DuckDB that refuses those plans. I ran three plans through stock substrait-java 0.103.0, declaring `precision_timestamp` at 9, 12 and 15, and Isthmus refuses all three the same way: `unsupported precision_timestamp precision N, max precision in Calcite type system is set to 6`. So the clamp makes the plan spec-valid, but a Calcite-based consumer still needs 6 or less unless it raises that limit the way Impala's type system does. Might be worth a line in the commit message: it makes the clamp a correctness fix rather than a DuckDB workaround. The test infrastructure squashed in as the first commit is 24667, and the exporter and the operator mappings come from 24741. Both are open for review, so if this sits on top of them instead, their review stays tied to what you have here and this change keeps only its own part; I am happy to do that rebase. If gating a prototype on unmerged changes slows you down, standalone now and a rebase once those two land works just as well from my side. Either way, could you add me as a reviewer? I would like to follow where this goes. -- To view, visit http://gerrit.cloudera.org:8080/24811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90a55a55e8416389847841a8495379759acd4ed7 Gerrit-Change-Number: 24811 Gerrit-PatchSet: 1 Gerrit-Owner: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2026 17:52:06 +0000 Gerrit-HasComments: No
