Aleksandr Efimov has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24811 )

Change subject: IMPALA-15282: Export Substrait plan from Calcite planner 
(prototype)
......................................................................


Patch Set 1:

Thanks. Your finding travelled: every Impala TIMESTAMP exports at fifteen
digits, so any plan over a table with a timestamp column was unreadable, not
only the ones using it. 24741 narrows the type to nine now.

Worth carrying into the prototype: the protobuf clamp does not fix a literal.
LiteralConverter writes the value in units of the precision it read, so
2020-01-01 becomes 1577836800 * 10^15, which does not fit an int64; setting
the field to nine afterwards leaves a different moment behind. We refuse those
plans for now, and I am filing it upstream.

How did the hackathon go, and is the pipelining direction carrying on? I am
about to ask dev@ whether Impala wants a Substrait input, and whether there is
a consumer behind it changes how that is worth asking.


--
To view, visit http://gerrit.cloudera.org:8080/24811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90a55a55e8416389847841a8495379759acd4ed7
Gerrit-Change-Number: 24811
Gerrit-PatchSet: 1
Gerrit-Owner: Jiyoung Yoo <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jiyoung Yoo <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Fri, 11 Sep 2026 18:43:09 +0000
Gerrit-HasComments: No

Reply via email to