Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24817 )
Change subject: IMPALA-15202: Add explicit CAST support between UUID and STRING ...................................................................... Patch Set 2: (9 comments) Thanks! Added the requested test cases. http://gerrit.cloudera.org:8080/#/c/24817/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test: http://gerrit.cloudera.org:8080/#/c/24817/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test@a71 PS1, Line 71: : > Please keep a couple old queries (or maybe all) as well, as they test diffe Restored all. http://gerrit.cloudera.org:8080/#/c/24817/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test@a145 PS1, Line 145: : : : : : : : : : : : : : : : : : : : > Can we keep these tests? Restored. http://gerrit.cloudera.org:8080/#/c/24817/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test@a251 PS1, Line 251: : : : : : : : : : : : : : : : : : : : : : : : : : > Can we keep these tests? Done http://gerrit.cloudera.org:8080/#/c/24817/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test@205 PS1, Line 205: ==== > You could also test it with CAST(NULL AS UUID) Done http://gerrit.cloudera.org:8080/#/c/24817/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test@245 PS1, Line 245: BIGINT,BIGINT > Can you add tests for casting non-constant strings to UUID? Done http://gerrit.cloudera.org:8080/#/c/24817/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test@246 PS1, Line 246: ==== > Uppercase input should be accepted and come back lowercase, e.g. CAST(CAST( Done http://gerrit.cloudera.org:8080/#/c/24817/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test@248 PS1, Line 248: SELECT id FROM iceberg_uuid_test WHERE uuid_col IS NULL ORDER BY id > Also add test for rejected strings like Done http://gerrit.cloudera.org:8080/#/c/24817/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test@249 PS1, Line 249: ---- RESULTS > Add negative tests for: Done. Added an extra test case showing CTAS is blocked for Iceberg too as there's no write support yet. http://gerrit.cloudera.org:8080/#/c/24817/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-uuid-type.test@250 PS1, Line 250: 4 > Can you add positive/negative test for: Done -- To view, visit http://gerrit.cloudera.org:8080/24817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51af55c6e343f7155cae22bf3714e293f31561d5 Gerrit-Change-Number: 24817 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 17:34:04 +0000 Gerrit-HasComments: Yes
