Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24534 )
Change subject: IMPALA-15161: Add GEOMETRY type + make WKB_EXPERIMENTAL default ...................................................................... Patch Set 27: (5 comments) http://gerrit.cloudera.org:8080/#/c/24534/27/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/24534/27/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@60 PS27, Line 60: public class HiveEsriGeospatialBuiltins { This could be renamed to GeospatialBuiltins as it's lost it's original purpose http://gerrit.cloudera.org:8080/#/c/24534/27/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@107 PS27, Line 107: new ST_GeomFromText(), nit: formatting seems odd http://gerrit.cloudera.org:8080/#/c/24534/27/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/24534/27/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@1719 PS27, Line 1719: isStringVal ? stringValGetValue : null, What about hoisting these conditions as: boolean isStringVal = symbolType == Type.STRING; String init = isStringVal ? initNullString : initNull; String getValue = isStringVal ? stringValGetValue : null; String serialize = isStringVal ? stringValSerializeOrFinalize : null; http://gerrit.cloudera.org:8080/#/c/24534/27/fe/src/main/java/org/apache/impala/catalog/Type.java File fe/src/main/java/org/apache/impala/catalog/Type.java: http://gerrit.cloudera.org:8080/#/c/24534/27/fe/src/main/java/org/apache/impala/catalog/Type.java@400 PS27, Line 400: public boolean containsGeometry() { Can we generalize the contains* methods? http://gerrit.cloudera.org:8080/#/c/24534/27/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/24534/27/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@182 PS27, Line 182: String typeName = t.isGeometry() ? "binary" : t.toSql().toLowerCase(); toHiveMetastoreType could help here -- To view, visit http://gerrit.cloudera.org:8080/24534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff29cb15ab45f3899bf453041e605a32f195c27 Gerrit-Change-Number: 24534 Gerrit-PatchSet: 27 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 18 Sep 2026 12:37:15 +0000 Gerrit-HasComments: Yes
