Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24534 )

Change subject: IMPALA-15161: Add GEOMETRY type + make WKB_EXPERIMENTAL default
......................................................................


Patch Set 17:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24534/17/tests/custom_cluster/test_geospatial_library.py
File tests/custom_cluster/test_geospatial_library.py:

http://gerrit.cloudera.org:8080/#/c/24534/17/tests/custom_cluster/test_geospatial_library.py@91
PS17, Line 91:   def test_wkb_experimental_extra(self, vector):
> PS23 removes the duplicate, but `geospatial-esri-extra` is still missing fr
thx, I didn't understand why it went missing, it seems that a rebase on a 
follow up review by Jason removed it

this also revealed a test bug - some tests returned raw geometry/binary, while 
returning geometry is not allowed at the moment



--
To view, visit http://gerrit.cloudera.org:8080/24534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ff29cb15ab45f3899bf453041e605a32f195c27
Gerrit-Change-Number: 24534
Gerrit-PatchSet: 17
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Tue, 15 Sep 2026 07:43:03 +0000
Gerrit-HasComments: Yes

Reply via email to