Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1921 PS1, Line 1921: <b>Purpose:</b> Returns the date of the <varname>weekday</varname> It seems somewhat implied, but maybe we should mention that the calling this with the current day returns the one a week later. E.g. select next_day('2018-07-12', 'thu'); --> 2018-07-19 This could also be added in the examples. http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1930 PS1, Line 1930: <codeph>"Sunday"</codeph>/<codeph>"SUN"</codeph>, Maybe make these follow the same case, if they're case insensitive? It seems odd to point out that case doesn't matter, but then have half of them in all-caps. I saw that these come from the original code but for the docs it seems nicer to have Sunday / Sun etc. http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941 PS1, Line 1941: Saturday December missing word? Also can you wrap the lines at 90 chars within the codeblock? http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941 PS1, Line 1941: SELECT NEXT_DAY The previous example above uses lower case and doesn't have a space before the opening "(". select next_day('2013... -- To view, visit http://gerrit.cloudera.org:8080/10893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715 Gerrit-Change-Number: 10893 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Thu, 12 Jul 2018 20:42:15 +0000 Gerrit-HasComments: Yes
