Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 )
Change subject: IMPALA-6677: [DOCS] Document the next_day function ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1921 PS1, Line 1921: <b>Purpose:</b> Returns the date of the <varname>weekday</varname> > It seems somewhat implied, but maybe we should mention that the calling thi Done http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1930 PS1, Line 1930: <codeph>"Sunday"</codeph>/<codeph>"SUN"</codeph>, > Maybe make these follow the same case, if they're case insensitive? It seem Done http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941 PS1, Line 1941: SELECT NEXT_DAY > The previous example above uses lower case and doesn't have a space before The original style for SQL is to use upper case for keywords even though not consistently followed. Will use upper case going forward and change the existing examples whenever possible. I would like to have space before opening paren unless there is a good reason not to use a space. Let me know if there is a reason that I am not aware of. http://gerrit.cloudera.org:8080/#/c/10893/1/docs/topics/impala_datetime_functions.xml@1941 PS1, Line 1941: Saturday December > missing word? Also can you wrap the lines at 90 chars within the codeblock? Done -- To view, visit http://gerrit.cloudera.org:8080/10893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dacc86ff69a1016b1863d9db66dd29fd832b715 Gerrit-Change-Number: 10893 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Thu, 12 Jul 2018 22:33:03 +0000 Gerrit-HasComments: Yes
