Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24822 )
Change subject: IMPALA-14598: Store HBO cache in Redis/Valkey ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/24822/5/fe/src/main/java/org/apache/impala/service/RedisCacheBackend.java File fe/src/main/java/org/apache/impala/service/RedisCacheBackend.java: http://gerrit.cloudera.org:8080/#/c/24822/5/fe/src/main/java/org/apache/impala/service/RedisCacheBackend.java@131 PS5, Line 131: byte[] serialized = jedis.get(buildKey(statsType, key)); We are utilising the statsType for generating keys here but they are ignored in InMemoryCacheBackend.getIfPresent(). It's been like that but I think it could cause collisions if future stats types share the same hash string. We could namespaec the in-memory keys for consistency. http://gerrit.cloudera.org:8080/#/c/24822/5/fe/src/main/java/org/apache/impala/service/RedisCacheBackend.java@191 PS5, Line 191: close We are not calling cacheBackend_.close() when the coordinator shuts down. A minor thing but I think JedisPool is never closed. -- To view, visit http://gerrit.cloudera.org:8080/24822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43a171bcd436f57bcff14ceaaaa98c0f7dcec769 Gerrit-Change-Number: 24822 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 21 Sep 2026 11:42:21 +0000 Gerrit-HasComments: Yes
