Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24886 )
Change subject: IMPALA-15374: Roll back current_row_ when undoing a level read ahead ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24886/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24886/2//COMMIT_MSG@25 PS2, Line 25: returned positions 1, 4, 7, 0 instead of 1, 3, 5, 0; 7 is past the end of the nit: wrap at 72? somehow claude doesn't seem to respect this rule http://gerrit.cloudera.org:8080/#/c/24886/2/tests/query_test/test_parquet_late_materialization.py File tests/query_test/test_parquet_late_materialization.py: http://gerrit.cloudera.org:8080/#/c/24886/2/tests/query_test/test_parquet_late_materialization.py@43 PS2, Line 43: customer_nested_multiblock_multipage nit: as we are using this at multiple tests, probably it would be better to add it during dataload -- To view, visit http://gerrit.cloudera.org:8080/24886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icaf0aab770d87505513b0168f52f96480eda3202 Gerrit-Change-Number: 24886 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2026 09:24:49 +0000 Gerrit-HasComments: Yes
