Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24886 )
Change subject: IMPALA-15374: Roll back current_row_ when undoing a level read ahead ...................................................................... Patch Set 2: (1 comment) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24886/1/be/src/exec/parquet/parquet-column-readers.h File be/src/exec/parquet/parquet-column-readers.h: http://gerrit.cloudera.org:8080/#/c/24886/1/be/src/exec/parquet/parquet-column-readers.h@449 PS1, Line 449: /// means that we already processed the Nth row completely, hence the initial value is > nit: How about adding some comments to elaborate? Updated the comment. -- To view, visit http://gerrit.cloudera.org:8080/24886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icaf0aab770d87505513b0168f52f96480eda3202 Gerrit-Change-Number: 24886 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2026 08:48:47 +0000 Gerrit-HasComments: Yes
