Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24883 )
Change subject: IMPALA-13052: Estimate reservoir sample memory in aggregations ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24883/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/24883/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@1190 PS1, Line 1190: private static long getFreePoolBytes(long bytes) { > this is not aggregation specific, some more central class would be better p Done in PS2: moved getFreePoolBytes() to PlannerContext, next to the other constants that mirror the backend. -- To view, visit http://gerrit.cloudera.org:8080/24883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6eec3daf7fea9b027ff0be9c95c6ee5a3cf323d Gerrit-Change-Number: 24883 Gerrit-PatchSet: 1 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2026 09:41:20 +0000 Gerrit-HasComments: Yes
