Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24883 )
Change subject: IMPALA-13052: Estimate reservoir sample memory in aggregations ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24883/2/fe/src/main/java/org/apache/impala/planner/PlannerContext.java File fe/src/main/java/org/apache/impala/planner/PlannerContext.java: http://gerrit.cloudera.org:8080/#/c/24883/2/fe/src/main/java/org/apache/impala/planner/PlannerContext.java@148 PS2, Line 148: public static long getFreePoolBytes(long bytes) { > nit: "get" sounds like if this was some config - maybe calculateFreePoolByt Done http://gerrit.cloudera.org:8080/#/c/24883/2/testdata/workloads/functional-planner/queries/PlannerTest/reservoir-sample-agg.test File testdata/workloads/functional-planner/queries/PlannerTest/reservoir-sample-agg.test: http://gerrit.cloudera.org:8080/#/c/24883/2/testdata/workloads/functional-planner/queries/PlannerTest/reservoir-sample-agg.test@1 PS2, Line 1: # IMPALA-13052: sample(), appx_median() and histogram() keep a reservoir sample of up > Can you add a test for a table with missing stats? Done, three cases on functional_parquet.alltypes. The interesting one is with DISABLE_HDFS_NUM_ROWS_ESTIMATE=1: the rows are unknown, so each group counts as one row. Full reservoirs would add 31MB per instance here, so I kept the low guess. OK with you? -- To view, visit http://gerrit.cloudera.org:8080/24883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6eec3daf7fea9b027ff0be9c95c6ee5a3cf323d Gerrit-Change-Number: 24883 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2026 17:24:17 +0000 Gerrit-HasComments: Yes
