Aleksandr Efimov has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24913 )

Change subject: IMPALA-15394: Add missing scan properties to the HBO scan key
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24913/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

http://gerrit.cloudera.org:8080/#/c/24913/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1942
PS2, Line 1942:     if (countStarSlot_ != null) sb.append("|<COUNT_STAR>");
> This reminds me there are some fields that are missing in the HBO key strin
Thanks, both were missing: they shared the key and input stats of a regular 
scan. PS3 adds <PARTITION_KEY_SCAN> and <SAMPLE:percent>. It also adds 
conjuncts on collection items, which filter the scan rows through the 
IsNotEmptyPredicate and were missing too.



--
To view, visit http://gerrit.cloudera.org:8080/24913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03183aa998f90bf834dba4ce9ad2f2e57fef1140
Gerrit-Change-Number: 24913
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Wed, 23 Sep 2026 10:13:22 +0000
Gerrit-HasComments: Yes

Reply via email to