Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24913 )
Change subject: IMPALA-15394: Add missing scan properties to the HBO scan key ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24913/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24913/3//COMMIT_MSG@20 PS3, Line 20: input rows count whole partitions (or all files of an Iceberg table). > We use sampledPartitions_ in this case by getSampledOrRawPartitions(). But Agreed, input_rows is too high there. But I'd keep <SAMPLE> in the key: without numRows only the EXPR_REWRITE key is stored and runs match by catalog version, so a sampled and a full scan of such a table would share the cardinality. Fixing input_rows for sampled scans could be a follow-up JIRA. WDYT? -- To view, visit http://gerrit.cloudera.org:8080/24913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03183aa998f90bf834dba4ce9ad2f2e57fef1140 Gerrit-Change-Number: 24913 Gerrit-PatchSet: 3 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2026 17:38:50 +0000 Gerrit-HasComments: Yes
