Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24914 )

Change subject: IMPALA-11917: Upgrade to GCC 15 and LLVM 19
......................................................................


Patch Set 5: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/24914/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24914/5//COMMIT_MSG@9
PS5, Line 9: pgrading Clang to a newer
           : version
Just curious: were there attempts to upgrade LLVM/CLANG to version 19 while 
keeping current GCC/toochain as-is or LLVM19 requires at least GCC15 to compile?

I guess might it be an option to split these two updates into separate patches 
when tracking perf regressions in the codegen-related parts.


http://gerrit.cloudera.org:8080/#/c/24914/5//COMMIT_MSG@10
PS5, Line 10: Upgrades to LLVM 19
BTW, what prevented upgrading up to version 22.1.8 or even to current 23.1.2 
right away?


http://gerrit.cloudera.org:8080/#/c/24914/5/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/24914/5/buildall.sh@76
PS5, Line 76: 19.1.1
Just curious: if staying with the LLVM19 line, why not to go with 19.1.7 -- the 
final minor/patch release in the line?  Is there anything special about 19.1.1 
release?



--
To view, visit http://gerrit.cloudera.org:8080/24914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7793748ff86d9c27530e135cb3b74319067a971
Gerrit-Change-Number: 24914
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 23 Sep 2026 20:12:29 +0000
Gerrit-HasComments: Yes

Reply via email to