Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24939
Change subject: IMPALA-15359: (Part 3) Fixed rebased Kudu source code to compile ...................................................................... IMPALA-15359: (Part 3) Fixed rebased Kudu source code to compile Fixes needed for be/src/kudu (util/security/rpc) rebased to d06637b27, plus a few Impala files outside be/src/kudu that call into it: - be/src/kudu/util/CMakeLists.txt: fill in the kudu-util-proto-deps wiring and mini_prometheus/protoc-gen-insertions/kudu_test_util fixes missed in the previous commit, and skip the new mini_prometheus symlink step, which Impala's build tree does not support. - be/src/gutil/endian.h: add FromHost128/ToHost128 (with a gbswap_128 helper), matching upstream kudu/gutil/endian.h, needed by the new IPv6 CIDR support in kudu/util/net/net_util.cc. gutil itself is otherwise out of scope for this rebase. - kudu/util/net/net_util.cc: avoid -Werror=return-type on a LOG(FATAL) default case. - kudu/rpc/service_queue.h: LifoServiceQueue::estimated_queue_length()/ estimated_idle_worker_count() became private upstream; friend impala::ImpalaServicePool, which reports them as metrics. - kudu/security/gssapi.cc, common/global-flags.cc: Kudu's init.cc now natively defines --spnego_keytab_file (IMPALA-12318 was merged upstream); stop redefining it in Impala and just declare it where used, to fix a duplicate-definition link error. - be/src/rpc/impala-service-pool.cc: LifoServiceQueue::Put() reverted from std::optional<InboundCall*>* to a plain InboundCall** out-param upstream; update the caller to match. - be/src/runtime/io/data-cache.cc: kudu::shared_lock was a pre-C++17 shim that upstream removed; use std::shared_lock instead. - be/src/util/webserver.cc: handle new HttpStatusCode enumerators (Created, NoContent, Forbidden, MethodNotAllowed, GatewayTimeout). The Kudu rebase changed kudu::logging::LogThrottler from an implicitly-trivial destructor to one defined out-of-line in kudu/util/logging.cc. That gave any KLOG_EVERY_N_SECS() call site a real link-time dependency on kudu_util, which we avoid to minimize the size of impala-profile-tool. Replace it with a local implementation. Updates tests for changed error text. Caps eager reservation in LifoServiceQueue as DataStreamService, ControlService, AdmissionControlService all initialize with max_queue_size_ = INT32_MAX. Change-Id: I74340c85407caf030bec94c03d6505a9b25e5180 Assisted-by: Claude Sonnet 5 (GitHub Copilot) --- M be/src/common/global-flags.cc M be/src/gutil/endian.h M be/src/kudu/rpc/service_queue.cc M be/src/kudu/rpc/service_queue.h M be/src/kudu/security/gssapi.cc M be/src/kudu/util/CMakeLists.txt M be/src/kudu/util/net/net_util.cc M be/src/rpc/impala-service-pool.cc M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/runtime/io/data-cache.cc M be/src/util/runtime-profile.cc M be/src/util/webserver.cc M tests/custom_cluster/test_restart_services.py 13 files changed, 132 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/24939/1 -- To view, visit http://gerrit.cloudera.org:8080/24939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I74340c85407caf030bec94c03d6505a9b25e5180 Gerrit-Change-Number: 24939 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]>
