Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24939 )

Change subject: IMPALA-15359: (Part 3) Fixed rebased Kudu source code to compile
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24939/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24939/1//COMMIT_MSG@9
PS1, Line 9: d06637b27
This is mainly a topic for the https://gerrit.cloudera.org/#/c/24937/, but it 
seems better to keep conversation in one patch.

Some info could be added here + in Jira about why d06637b27 is used instead of 
a released version ("Kudu 1.18.1 was released on January 9, 2026.").

>From my part I prefer the new version due to ipv6 support for krpc 
>(e.g.https://github.com/apache/kudu/commit/8ae4fe1b04a0625aae59269f675cee424196603d).


It would be nice to bump again if they have a new release, just to make our 
dependencies clearer.


http://gerrit.cloudera.org:8080/#/c/24939/1/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:

http://gerrit.cloudera.org:8080/#/c/24939/1/be/src/util/runtime-profile.cc@a1908
PS1, Line 1908:
Define our own version of this instead?



--
To view, visit http://gerrit.cloudera.org:8080/24939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74340c85407caf030bec94c03d6505a9b25e5180
Gerrit-Change-Number: 24939
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Fri, 25 Sep 2026 08:09:54 +0000
Gerrit-HasComments: Yes

Reply via email to