Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24881 )
Change subject: IMPALA-15371: Support IS [NOT] NULL on VARIANT columns ...................................................................... Patch Set 2: (1 comment) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/24881/2/fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java File fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java: http://gerrit.cloudera.org:8080/#/c/24881/2/fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java@66 PS2, Line 66: List<Type> types = new ArrayList<>(Type.getSupportedTypes()); > Isn't it better to add it ad Type.java? Supported types only contain scalar types, and curently VARIANT is not a scalar type. Allowing non-scalar types in supported types could make sense, but it needs a somewhat bigger change. Also not that future-proof as there could be other cases where we loop over supported types and accidentally include VARIANT when we should exclude it. But I can give it a try if you feel strong about it. -- To view, visit http://gerrit.cloudera.org:8080/24881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0b17821f6c8a988abf93494b7dbeb8f6f7db216 Gerrit-Change-Number: 24881 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2026 17:12:59 +0000 Gerrit-HasComments: Yes
