Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25018 )
Change subject: IMPALA-15481: Calcite planner: Add NVL2 support ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/25018/2/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/25018/2/tests/query_test/test_exprs.py@72 PS2, Line 72: vector.set_exec_option('planner', 'CALCITE' if IS_CALCITE_PLANNER else 'ORIGINAL') While I realize this proves it will run on both (which is good!), it's probably overkill. Let's remove lines 72 and 73. It will run on the original by default. Yes, there's a hole on Calcite that if it's buggy, it will fallback to original planner, but we have that problem in many other places. There is a short term goal to ensure that this will not happen, prolly in the next few months. -- To view, visit http://gerrit.cloudera.org:8080/25018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2be3b6baacc2e067ffedd70005511e20e4216bd Gerrit-Change-Number: 25018 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 22:34:33 +0000 Gerrit-HasComments: Yes
