Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24472 )

Change subject: IMPALA-12232: Validate JWT aud/iss claims
......................................................................


Patch Set 15: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24472/12/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java
File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java:

http://gerrit.cloudera.org:8080/#/c/24472/12/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@364
PS12, Line 364:         
"[{\"jwksFilePath\":\"%s\",\"issuerClaims\":[\"issuer2\"]}]",
> Done in PS13. I updated testJwtAuthWithWrongIssuerClaim to use THttpClientW
Done


http://gerrit.cloudera.org:8080/#/c/24472/12/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@439
PS12, Line 439:     String oauthServers = String.format(
> Done in PS13. I updated testJwtAuthWithWrongAudienceClaim to use THttpClien
Done



--
To view, visit http://gerrit.cloudera.org:8080/24472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a00b126359f2bc7e2f73d894cebc2b9014c7375
Gerrit-Change-Number: 24472
Gerrit-PatchSet: 15
Gerrit-Owner: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Anonymous Coward (934)
Gerrit-Reviewer: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Gokul Kolady <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Tue, 06 Oct 2026 18:55:58 +0000
Gerrit-HasComments: Yes

Reply via email to