Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/25041 )
Change subject: IMPALA-15212: Iceberg UUID ORC read support ...................................................................... Patch Set 1: Code-Review+1 (3 comments) LGTM! http://gerrit.cloudera.org:8080/#/c/25041/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/25041/1//COMMIT_MSG@25 PS1, Line 25: Range predicates never skip data as the scan : evaluates them in unsigned byte order. And ORC keeps no min/max for BINARY AFAIK. http://gerrit.cloudera.org:8080/#/c/25041/1/be/src/exec/orc/hdfs-orc-scanner.cc File be/src/exec/orc/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/25041/1/be/src/exec/orc/hdfs-orc-scanner.cc@1398 PS1, Line 1398: // UUID and STRING both use the STRING predicate type. Skip predicates that : // mix them, since a UUID value is 16 raw bytes, not text. : bool is_uuid_slot = slot_desc->type().type == TYPE_UUID; : bool is_uuid_literal = const_expr->type().type == TYPE_UUID; : if (is_uuid_slot != is_uuid_literal) continue; nit: UuidCompatibility makes UUID incompatible with every other type, so uuid_col = 'str' fails analysis. It should be a DCHECK. http://gerrit.cloudera.org:8080/#/c/25041/1/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/25041/1/testdata/data/README@1025 PS1, Line 1025: Iceberg Java API nit: can you add the version? -- To view, visit http://gerrit.cloudera.org:8080/25041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id736a9ea852892b610281df9105c82e4a4ce42da Gerrit-Change-Number: 25041 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Oct 2026 16:34:10 +0000 Gerrit-HasComments: Yes
