Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/25041 )
Change subject: IMPALA-15212: Iceberg UUID ORC read support ...................................................................... Patch Set 2: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/25041/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/25041/1//COMMIT_MSG@25 PS1, Line 25: Range predicates are still evaluated on the : pushed search arguments (16-byte unsig > And ORC keeps no min/max for BINARY AFAIK. We've mentioned it in the previous sentence but still tweaked this line a little to make it clearer. http://gerrit.cloudera.org:8080/#/c/25041/1/be/src/exec/orc/hdfs-orc-scanner.cc File be/src/exec/orc/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/25041/1/be/src/exec/orc/hdfs-orc-scanner.cc@1398 PS1, Line 1398: // Impala UUID and STRING both map to orc::PredicateDataType::STRING above. The FE : // does not plan mixed UUID vs string literals (UuidCompatibility). : DCHECK((slot_desc->type().type == TYPE_UUID) : == (const_expr->type().type == TYPE_UUID)); : // Skip if the file schema contains unsupporte > nit: UuidCompatibility makes UUID incompatible with every other type, so uu Done http://gerrit.cloudera.org:8080/#/c/25041/1/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/25041/1/testdata/data/README@1025 PS1, Line 1025: Iceberg Java API > nit: can you add the version? Done -- To view, visit http://gerrit.cloudera.org:8080/25041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id736a9ea852892b610281df9105c82e4a4ce42da Gerrit-Change-Number: 25041 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Oct 2026 17:16:34 +0000 Gerrit-HasComments: Yes
