Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 )
Change subject: IMPALA-5031: Fix undefined behavior: memset NULL ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10948/3/be/src/util/ubsan.h File be/src/util/ubsan.h: http://gerrit.cloudera.org:8080/#/c/10948/3/be/src/util/ubsan.h@26 PS3, Line 26: class Ubsan { > bikeshedding opportunity here: when I saw the name 'ubsan.h' and the name o I had intended for this class to include safe versions of other undefined operations, not all of which are memory: https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html Thoughts? -- To view, visit http://gerrit.cloudera.org:8080/10948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18fa02dc887a42a94c6f81e4923d17568f2184f2 Gerrit-Change-Number: 10948 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 17 Jul 2018 21:48:50 +0000 Gerrit-HasComments: Yes
