Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 )
Change subject: IMPALA-5031: Fix undefined behavior: memset NULL ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10948/3/be/src/util/ubsan.h File be/src/util/ubsan.h: http://gerrit.cloudera.org:8080/#/c/10948/3/be/src/util/ubsan.h@26 PS3, Line 26: class Ubsan { > I had intended for this class to include safe versions of other undefined o I think in those cases I'd probably put each of the methods into wherever they make sense, since these aren't workarounds for UBSAN so much as safe variants of utility code. eg this one would be in memory.h, and overflow-safe math code could be in safe_math.h (we have such a header in kudu/util fwiw). Bit-shift behavior probably belongs in bit-util.h etc. If others disagree with me though I'm not gonna be too much of a stickler. -- To view, visit http://gerrit.cloudera.org:8080/10948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18fa02dc887a42a94c6f81e4923d17568f2184f2 Gerrit-Change-Number: 10948 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 17 Jul 2018 22:25:19 +0000 Gerrit-HasComments: Yes
