Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 )
Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query ...................................................................... Patch Set 11: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/10415/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10415/9//COMMIT_MSG@14 PS9, Line 14: > nit:long line can you include an example too? http://gerrit.cloudera.org:8080/#/c/10415/9/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/10415/9/be/src/runtime/coordinator-backend-state.cc@600 PS9, Line 600: avg_profile_->AddInfoString("num instances", lexical_cast<string>(num_instances_)); : } > maybe add other members of resource_utilization_ as well here can you address this too? http://gerrit.cloudera.org:8080/#/c/10415/9/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: http://gerrit.cloudera.org:8080/#/c/10415/9/be/src/service/query-options-test.cc@146 PS9, Line 146: {-1, I64_MAX}}, > I just ran it through clang-format :). i agree, looks more consistent now -- To view, visit http://gerrit.cloudera.org:8080/10415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20 Gerrit-Change-Number: 10415 Gerrit-PatchSet: 11 Gerrit-Owner: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Jul 2018 23:39:04 +0000 Gerrit-HasComments: Yes