Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 )
Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query ...................................................................... Patch Set 8: (6 comments) There's some more cleanup to do after my first pass... http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/runtime/coordinator-backend-state.h@198 PS8, Line 198: backend For this fragment instance http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/runtime/coordinator-backend-state.h@207 PS8, Line 207: /// and peak_mem_counter_ from profile_. peak_mem_counter_ was removed... http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/runtime/coordinator-backend-state.cc@294 PS8, Line 294: resource_utilization_.Merge(entry.second->resource_utilization_); I'm considering adjusting this to use an O(1) algorithm - Update() could return the delta in resource consumption and this could just be a Merge(). http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/runtime/coordinator.h@177 PS8, Line 177: backend This isn't accurate, could be fragment instances, backend or query. http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/service/query-options.h@135 PS8, Line 135: TQueryOptionLevel::ADVANCED)\ Need to fix tabs http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/10415/8/be/src/service/query-options.cc@682 PS8, Line 682: // Parse the scan bytes limit and validate it. Useless comment. -- To view, visit http://gerrit.cloudera.org:8080/10415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20 Gerrit-Change-Number: 10415 Gerrit-PatchSet: 8 Gerrit-Owner: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Jul 2018 19:12:08 +0000 Gerrit-HasComments: Yes
