Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11047 )
Change subject: IMPALA-5031: Fix undefined behavior: right-shifting too far ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11047/2/be/src/exec/hdfs-avro-scanner-ir.cc File be/src/exec/hdfs-avro-scanner-ir.cc: http://gerrit.cloudera.org:8080/#/c/11047/2/be/src/exec/hdfs-avro-scanner-ir.cc@264 PS2, Line 264: if (len.val == 0) { UNLIKELY()? -- To view, visit http://gerrit.cloudera.org:8080/11047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5be92912198af2a5e00053ceb9a4fab43ca6bb8 Gerrit-Change-Number: 11047 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 25 Jul 2018 07:10:11 +0000 Gerrit-HasComments: Yes
