Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11047 )
Change subject: IMPALA-5031: Fix undefined behavior: right-shifting too far ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11047/3/be/src/exec/hdfs-avro-scanner-ir.cc File be/src/exec/hdfs-avro-scanner-ir.cc: http://gerrit.cloudera.org:8080/#/c/11047/3/be/src/exec/hdfs-avro-scanner-ir.cc@263 PS3, Line 263: if(LIKELY(slot_byte_size == 4 || slot_byte_size == 8 || slot_byte_size == 16)) { > I think I preferred the old version :). We don't need a runtime check for t It doesn't look sort-of free to me - The Compiler Explorer reports every path using between one and three cmp calls: https://godbolt.org/g/a1mUiD -- To view, visit http://gerrit.cloudera.org:8080/11047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5be92912198af2a5e00053ceb9a4fab43ca6bb8 Gerrit-Change-Number: 11047 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 27 Jul 2018 17:20:08 +0000 Gerrit-HasComments: Yes
